localize strings for jupyterlab-lsp #557
Conversation
There was a problem hiding this comment.
Fantastic work, thank you for starting this effort!
I saw the test are failing for rename, and had a look into how this could be potentially improved - please see my suggestion in the comment.
Please let us know if we can help in any way. Do not worry about tests failing on pip check - this is a known issue that I am going to address soon.
|
Thanks @krassowski! I added your suggestion and looks to be working. Do you have any ideas for the diagnostics.spec.ts test errors? |
packages/jupyterlab-lsp/src/features/diagnostics/diagnostics.ts
Outdated
Show resolved
Hide resolved
|
I gave it a go on binder and it is looking good. The only place where I found an opportunity for improvement was in the Severity column of diagnostics panel:
which is implemented here: |
Perfect, thanks for finding that @krassowski. I've just added that as well as the 'panel columns' menu that was also missing. |
|
Apropos of nothing (aside from a separate pr): the jupyter_server api is
changing for translations. We should take a look at any server-built
strings that aren't data (e.g. specs) and see if we want to add _i18n
anywhere.
One thing I added over on the crazy kernel branch (which I swear I'll warm
up soon, because ls-ws) was a "jupyter lsp troubleshoot" CLI that could do
some troubleshooting... It had some non-generated some strings.
|
|
Thank you @JessicaBarh! |
|
Sorry @krassowski haven't been able to get back on that the past week, thanks for finishing that! |
References
Code changes
any text displayed on the UI is made localizable using the TranslationBundle and ITranslator from @jupyterlab/translation
User-facing changes
User will be able to use jupyterlab-lsp extension in prefered language given that the language pack is installed.
Can also be viewed by using the language settings to enable string prefix for all localized strings:
Backwards-incompatible changes
Chores